TeamReview Forum Rss Feed

New Post: Team Review with VS 2005 and TFS 2008

vermeeca — Mon, 16 Nov 2009 21:01:38 GMT

Nevermind, got it resolved. I was missing the log file that indicated a NullReferenceException was being thrown. My resolution to the error was to uninstall the TFS Power Tools.

New Post: Team Review with VS 2005 and TFS 2008

vermeeca — Mon, 16 Nov 2009 20:05:49 GMT

Hi there,

Our current setup is TFS 2008, but with Visual Studio 2005 as our client for development. I imported the Work Item type successfully into our Team Project and have installed the VS 2005 Team Review client, but when I try to create a Code Review Response WI from VS 2005 I get the 'TeamReview Help' window. Upgrading my solution to VS 2008 will let me create the WI successfully, but that's not really a sustainable option for us at the moment.

Is there a trick to getting VS 2005 to work with Team Review on a TFS 2008 server that I'm not aware of?

Thanks,

Craig

New Post: TeamReview incompatable with with VS2008 PowerCommands?

harveyalison — Thu, 29 Oct 2009 09:37:35 GMT

Hello,

With the VS2008 PowerCommands addin installed, the following appears in the TeamReview log file on VS startup, and the TeamReview work items fail to work from the context menu in a code window:

29/10/2009 09:30:54 System.NullReferenceException: Object reference not set to an instance of an object.
   at Microsoft.PowerCommands.Commands.ShowAllFilesCommand.CanExecute(OleMenuCommand command)
   at Microsoft.PowerCommands.Commands.DynamicCommand.OnBeforeQueryStatus(Object sender, EventArgs e)
   at Microsoft.VisualStudio.Shell.OleMenuCommand.get_OleStatus()
   at Microsoft.VisualStudio.Shell.OleMenuCommandService.Microsoft.VisualStudio.OLE.Interop.IOleCommandTarget.QueryStatus(Guid& guidGroup, UInt32 nCmdId, OLECMD[] oleCmd, IntPtr oleText)
   at Microsoft.VisualStudio.Shell.Package.Microsoft.VisualStudio.OLE.Interop.IOleCommandTarget.QueryStatus(Guid& guidGroup, UInt32 nCmdId, OLECMD[] oleCmd, IntPtr oleText)
   at Microsoft.VisualStudio.CommandBars._CommandBars.get_Item(Object Index)
   at TeamReview.VSNetAddIn.Connect.BuildMenu()
   at TeamReview.VSNetAddIn.Connect.OnConnection(Object application, ext_ConnectMode connectMode, Object addInInst, Array& custom)

Nb: when selecting the TeamReview actions on the context menu, a modal dialog is displayed containing the following text:

"TeamReview is the most complete solution for Team System Code Reviews: a specific work item type and a Visual Studio add-in for a completely in IDE code review experience.

To use TeamReview Visual Studio must be online, a Visual Studio Solution must be open and within a Team System workspace mapping. Additionally Team Projects that that will store work items must have the Code Review Response work item type.

To setup a Team System project for TeamReview usage please use the following directions from the TeamReview codeplex site.

Thank You,
TeamReview contributors"

Anyone else see this, or know of a workaround?

Many thanks, Harvey

New Post: Custom Code Reviewer List

jbbrown — Fri, 16 Oct 2009 17:12:40 GMT

mtanner -

The connection between TFS Code Review Workflow and TeamReview is a very common one and should address your need.

"TFS Code Review Workflow" has a work item type called "Code Review" and a step for creating a "Code Reviewers" group. Then in step 1 of the TeamReview workflow you wouldn't create a Task and assign it to a reviewer, instead you would create the new "Code Review" work item type and assign it to one of the people you have added to the "Code Reviewers" group.

Let me know if you have any follow-up questions.

JB Brown, Team System MVP

New Post: Custom Code Reviewer List

mtanner — Fri, 16 Oct 2009 16:18:48 GMT

Actually, I'm not referring to the "Create Code Review Response", but the workflow step just before that (step 1 in the overview flowchart PDF file). I'm referring to the task assignment of a developer when coding is complete and ready for check in. I don't want the developer to have the ability to choose another junior developer as the code reviewer, thus I need to be able to control the list of code reviewers that can be selected when the code is ready for review.

New Post: Custom Code Reviewer List

bluess57 — Thu, 15 Oct 2009 23:23:37 GMT

Just to clarify, you are talking about the "Create Code Review Response" dialog?

This is a feature that could be implemented, if there is interest.

At the moment, as you are aware, TeamReview retrieves "all users" in the team project.

One possible way to achieve it (if you want to change your source code in the meantime), is to Create a project group say "Code Reviewers", assign users into the group. Modify TFSService.cs methods SetUsers() and AddCodeChangers().

New Post: Custom Code Reviewer List

mtanner — Thu, 15 Oct 2009 20:42:41 GMT

Is it possible to have/create a custom list of code reviewers that will populate the Assign To field? I'd like to have a subset of the developers available for selection in the Assign To field when a developer checks in code and creates the task for code review.

New Post: Unable to create new code review response

ofekshilon — Wed, 14 Oct 2009 07:51:44 GMT

Thanks! - that does the trick.

CreateToolwindow2 now also returns a non-null programmableObject. I already changed ComVisible to true, but only now does it take effect. Weird. Anyway, I'm now able to get by without the onLoad workaround too.

Thanks again!

-Ofek

New Post: Unable to create new code review response

bluess57 — Wed, 14 Oct 2009 02:12:07 GMT

The problem arises as we are trying to coordinate changes between the open work item and the code view replay grid. (The documentservice is holding an edit lock)

The following will resolve the situation, but you will have to live without synchronisation between an open work item and the replay grid.

In method SetTfsServer() in CodeReviewReplayWindow.cs you can comment out these two lines...

//documentService.DocumentAdded -= new DocumentService.DocumentServiceEventHandler(documentService_DocumentAdded);

//documentService.DocumentAdded += new DocumentService.DocumentServiceEventHandler(documentService_DocumentAdded);

New Post: Unable to create new code review response

bluess57 — Tue, 13 Oct 2009 22:55:11 GMT

Setting the ComVisible Attribute to true in the TeamReview assembly, means in Command\ShowReplayWindowCommand.cs, the programmableObject should now be not null at this line:-

toolWindow = (

</font>

Window2)windows2.CreateToolWindow2(addIn, asm.Location,"TeamReview.UI.CodeReviewReplayWindow", "Code Review Replay", GuidString, ref programmableObject);

I've reproduced the same error 'TF26194' and looking into it...

New Post: Unable to create new code review response

ofekshilon — Tue, 13 Oct 2009 11:29:18 GMT

This issue seems solved - thanks! I'm now able to select & replay reviews. BTW, not sure what the ComVisible attribute fixed - it doesn't eliminate the need for your onLoad workaround.

Anyway, the front moved now to a new issue: now I'm unable to change review items created from the editor context menu (say, change the status to 'closed'). When I do, the error 'TF26194: The value for this field cannot be changed' pops up. I cannot modify such items from the team explorer as well. I *can* successfully modify review items created from the team explorer. All in all, it seems something is now amiss in the creation process. Any directions, as to how I can debug that?

Thanks again!

New Post: Unable to create new code review response

bluess57 — Mon, 12 Oct 2009 22:33:08 GMT

Aaaarrrgghh,

In the TeamReview project, under the properties folder, open AssemblyInfo.cs and change the following ComVisible from false to true. All should be ok after that.

[assembly: ComVisible(true)]

New Post: TeamReviewing system without TFS

bluess57 — Mon, 12 Oct 2009 22:17:34 GMT

I'm sure there are plenty around, bing/google is your friend.

I found this one a while ago, not an endorsement by any means,

http://smartbear.com/codecollab.php

New Post: Unable to create new code review response

bluess57 — Mon, 12 Oct 2009 22:07:47 GMT

As you found in ActivateToolwindow() , the programmableObject is returning null. This is the cause of the issue.

I have some code modifications which I will send to you to try out, which work around this.

For debugging, right click on the TeamReview project in solution explorer, goto the Debug page.

Fill out these:-

Start external program -> C:\Program Files\Microsoft Visual Studio 8\Common7\IDE\devenv.exe

Start options command line arguments -> /resetaddin TeamReview.VSNetAddIn.Connect

Working directory -> C:\Program Files\Microsoft Visual Studio 8\Common7\IDE

Once you compile the project, usually manually copy the binary to the Team review directory (default is C:\Program Files\TeamReview\TeamReview (2005) )

Then right click project, select from menus -> Debug start new instance

New Post: TeamReviewing system without TFS

Whatty — Mon, 12 Oct 2009 20:16:00 GMT

Good afternoon,

Are there any solutions available that are not dependent upon TFS?

Thanks in advance.

Whatty

New Post: Unable to create new code review response

ofekshilon — Mon, 12 Oct 2009 19:36:44 GMT

bluess57, thanks. I had already set breakpoints around. I tried some printf-debugging, figuring maybe the action somehow happens before I get to attach to the debugee VS. E.g., the code you quoted was instrumented to read:

                if (shellDTE.Solution.FullName.Length > 0)
                {
                    Instrumentation.Trace("Shell");
                    GetVersionControl();
                }

- all unsuccessful.

However, your other pointer gives a good lead! turns out, in ActivateToolWindow() the line

                CodeReviewReplayWindow replayWindow = programmableObject as CodeReviewReplayWindow;

returns replayWindow as null, thereby not calling the shell setter. Any idea what can cause this? How can I debug my way into such an instantiation?

[Edit:] Maybe I'm going the wrong way about debugging here. I installed the latest TeamReview public release, and ever since I'm debug-compiling the source and replacing the installed dll with mine. Now the said CreateToolWindow2 returns a null into programmableObject. Perhaps the control GUID has changed since the public build, so the compiled version isn't visible to the COM runtime? How do you recommend debugging addons?

New Post: Unable to create new code review response

bluess57 — Mon, 12 Oct 2009 01:24:08 GMT

I'll investigate further, solutionEvents_Opened may be some redundant code , I'll have to check.

In CodeReviewReplayWindow.cs, GetVersionControl() is called within the property Shell - setter, when there is a solution name. shellDTE should have a value here.

        public DTE2 Shell
        {
            get { return shellDTE; }
            set
            {
                shellDTE = value;
              
                if (shellDTE.Solution == null)
                    return;

                if (shellDTE.Solution.FullName.Length > 0)
                {
                    GetVersionControl();
                }

                ReBind();
            }
        }

ShowReplayWindowCommand.cs sets the Shell property after the CodeReviewReplayWindow is instantiated.

Set Breakpoints in TFSService.cs method SetTeamProject(). Confirm that variables tfs, tfsExt, versionControlServer all get values,

Debugging these Addins are a pain, I'm working on switching it to a VS package for better VS integration/ Test / Debug / Deploy since it can run in the VS experimental hive.

New Post: Unable to create new code review response

ofekshilon — Sat, 10 Oct 2009 21:37:27 GMT

Me again. I decided to take on the opportunity and try on some C# (first time for me, let alone VSX, so please bear with me - I'm just trying to help). I compiled a debug version and got to debugging it. The direct culprit seems to be CodeReviewReplayWindow.documentService being null. It is set in SetTfsServer(), that as far as I can tell is never called.

I tried trapping what I perceive to be the flow leading to SetTfsServer: GetVersionControl isn't called, neither is solutionEvents_Opened. Not sure what event this handles, and where it is assigned to it . I can say that TFSService.Configure() is called.

Another 2c (that certainly may be due to my utter c# ignorance): when stepping through various CodeReviewReplayWindow methods, trying to set a watch over documentService typically shows "Could not evaluate expression" under 'Value' column, whereas I can easily enough set watch to its sibling CodeReviewReplayWindow.shellDTE. (who is likewise null, say around the constructor). Don't understand it and can't say if it's relevant - just thought I'd through it in.

Any ideas? (Debugging tips would be much appreciated too).

New Post: Unable to create new code review response

ofekshilon — Thu, 08 Oct 2009 04:38:47 GMT

Of course - the solution is open. Tried on 3 different solutions.

New Post: Unable to create new code review response

bluess57 — Thu, 08 Oct 2009 03:15:35 GMT

Just to add, TeamReview has no dependency on PowerTools/Powertoys.

To Replay a code review, you will need the solution open at the time.