TeamReview Work Item Rss Feed

Created Issue: Exception on VS load (2005 version) [4789]

richbeales — Mon, 09 Nov 2009 13:57:28 GMT

TeamReview: 1.1.2.0 on VS 2005 Pro

I get the following exception in the TeamReview.log

09/11/2009 13:49:57 System.NullReferenceException: Object reference not set to an instance of an object.
at Microsoft.VisualStudio.TeamFoundation.PowerToys.WorkItemDocumentTracker.ProcessDocument(IVsWindowFrame frameWindow)
at Microsoft.VisualStudio.TeamFoundation.PowerToys.WorkItemDocumentTracker.OnElementValueChanged(UInt32 elementid, Object varValueOld, Object varValueNew)
at Microsoft.VisualStudio.CommandBars._CommandBars.get_Item(Object Index)
at TeamReview.VSNetAddIn.Connect.BuildMenu()
at TeamReview.VSNetAddIn.Connect.OnConnection(Object application, ext_ConnectMode connectMode, Object addInInst, Array& custom)

Have tried reinstall, but same issue.

Running Visual Studio 2005 Professional on Windows XP, with Team explorer 2005 SP1 installed (+power tools) as well as Team Foundation Sidekicks and ViEmu.

Created Issue: Check for Add-in Folder during installation [4715]

cook_david — Tue, 03 Nov 2009 22:46:10 GMT

Installation fails with the attached error if the Add-in folder does not exist:
Error 1001. Failure to process file ...\TeamReview.VSNetAddIn.Addin'.
By manually creating the folder (For example C:\Documents and Settings\<username>\Application Data\Microsoft\MSEnvShared\AddIns in XP and C:\Users\<username>\AppData\Roaming\Microsoft\MSEnvShared\Addins in Windows 7) resolves the problem, but the installer should detect this.

Commented Issue: Code Review of entire changeset [3940]

SLevy — Mon, 02 Nov 2009 16:12:52 GMT

It would be nice to be able to perform a codereview for an entire changeset, and be able to review each line of code in the changeset.
There is a project called Malevich that has a nice view, but the add-in/workitem model really would work well for our team.

To make it simpler if we could select multiple snippets from different files, and be able to replay each item that would also work.
Essentially a way to code review blocks of non contiguous code.

Thanks
Jon Shern
Comments: ** Comment from web user: SLevy **

Agree that review of entire changeset is ideal.

Closed Issue: Installation with multiple VS versions [4386]

JBBrown — Wed, 21 Oct 2009 05:25:18 GMT

---
My bad! I missed the two separate (2005/2008) downloads.

Suggested clarification: Process editor menu items come only as part of the TFS power tools (at least for 2005). Would be helpful to mention that - I spent a while figuring out why they are missing on my machine.

Closed Issue: Chrash in "Code Review Replay" when hitting open workitem button [3889]

JBBrown — Wed, 21 Oct 2009 05:22:28 GMT

Visual Studio 2005 crashes when I hit the open workitem button in the Code Review Replay Window.
documentService is null

private void ShowWorkItem(int id)
{
// ThomasD : documentService is null
IWorkItemDocument wiDoc = documentService.GetWorkItem(TFSService.TeamFoundationServer, id, this);
try
{
documentService.ShowWorkItem(wiDoc);
}
finally
{
wiDoc.Release(this);
}
}
Comments:

release 1.1.2

Closed Issue: Vs2008 (under Vista SP2) crash after save new created Team Review Response [3865]

JBBrown — Wed, 21 Oct 2009 05:22:19 GMT

Problem seems appairs only if Vs2008 is started with no-admin rights. After crash Team Review Response is correctly saved.
Using admin rights all seems work fine.
Gianluca
Comments:

release 1.1.2

Closed Issue: VS 2005 crashes right after solution is opened [3688]

JBBrown — Wed, 21 Oct 2009 05:22:12 GMT

I upgraded from previous version to version 1.1.0 (uninstalled the old version and installed the new version) and my Visual Studio 2005 crashes right after I open any solution from TFS. There is nothing in TeamReview's log file. If I disable the addin, everything is ok.
Comments:

release 1.1.2

Closed Issue: Crash under Windows Vista SP2 VS 2005 (shellDTE not set correctly) [3888]

JBBrown — Wed, 21 Oct 2009 05:21:52 GMT

...\1.1.1\2005\TeamReview\Command\ShowReplayWindowCommand.cs line 84:

// ThomasD: this hides the member 'replayWindow'
// My opinion is, that this is the cause for a shellDTE which is null in the CodeReviewReplayWindow
// CodeReviewReplayWindow replayWindow = programmableObject as CodeReviewReplayWindow;
replayWindow = programmableObject as CodeReviewReplayWindow;
if (replayWindow != null)
{
replayWindow.Shell = shellDTE;
}

This should be fixed with setting ComVisible(true) in Assembly.cs
Comments:

Release 1.1.2

Created Issue: Menu 'Sql Editor Context Menu' does not exist in this Visual Studio installation. [4430]

pskumarweb — Fri, 09 Oct 2009 20:32:17 GMT

TeamReview: 1.1.1.0
Visit: http://TeamReview.codeplex.com
TeamReview: 1.1.1.0
Visit: http://TeamReview.codeplex.com
TeamReview: 1.1.1.0
Visit: http://TeamReview.codeplex.com
Menu 'Sql Editor Context Menu' does not exist in this Visual Studio installation.
An exception has been encountered.
Please file a bug or contact a TeamReview member at http://TeamReview.codeplex.com with the contents of C:\Program Files\TeamReview\TeamReview (2008)\TeamReview.log
An exception has been encountered.
Please file a bug or contact a TeamReview member at http://TeamReview.codeplex.com with the contents of C:\Program Files\TeamReview\TeamReview (2008)\TeamReview.log

Created Issue: Missing assignees [4403]

OfekShilon — Tue, 06 Oct 2009 11:12:38 GMT

I think the 'assign to' list includes only users from project user groups (contributors, administrators, etc.), and *not* from global lists.
The users I wish to assign to are in Team Foundation Administrators. Can at least this group be added?
Thanks.

Created Issue: Installation with multiple VS versions [4386]

OfekShilon — Sun, 04 Oct 2009 07:31:52 GMT

I have VS2005 and VS2008 installed side by side, for use with different projects. TeamReview apparently installed its 2008 version, without me having a choice - when I actually wanted to check it out on some VS2005 projects.
It would be great if the TeamReview installer could identify a situation of multiple VS installations, and let me check which ones I'd like to integrate with.

Closed Issue: Changeset textbox is always black - can't read text (version 1.1.0) [3818]

JBBrown — Thu, 24 Sep 2009 01:34:17 GMT

The changeset text box is always displayed with black fill. When you select a changeset, it appears that the value is loaded into the control, but you can't read the value.
Comments: Resolved with changeset 30361.

Closed Issue: Add shortcut key for the New Code Review Response [3579]

JBBrown — Thu, 24 Sep 2009 01:34:16 GMT

JB: I will slate this for the next release - 1.1.1

Since I'm a keyboard user, I'd like to be able to assign a shortcut key to the New Code Review Response window.
Comments: Resolved with changeset 30361.

Created Issue: Code Review of entire changeset

jonshern — Mon, 10 Aug 2009 21:13:52 GMT

Commented Issue: Problem creating response linked to WorkItem in different Team Project

JBBrown — Thu, 06 Aug 2009 04:27:51 GMT

Thank you for pointint out this issue and the providing the great suggestion. We will look into creating this option.

JB
------

Ik was facing the following problem. I was creating Code Review Response (at least, I thought I was), but no Work Items were created. After trying some things, I found the problem. The workitem i was linking to was in a different Tema Project than the solution. Creating a Code Review Response doesnt work then.

I think there are two problems here:
1. No error message is displayed, altough nothing gets created.
2. I would really like to link to a workitem in a different team project. We have a team project which is used as bug tracking project for the IT department. Would it be possible to add this possibility?
Comments: Associated with changeset 24288.

Closed Issue: Problem creating response linked to WorkItem in different Team Project

JBBrown — Wed, 05 Aug 2009 02:43:58 GMT

Commented Issue: Avoid including Team System assemblies in distro

JBBrown — Tue, 04 Aug 2009 21:01:34 GMT

Just ship the TeamReview dlls and resources, everything else should be a pre-req
Comments: ** Comment from web user: JBBrown **

This fix was published today in release 1.1.1 - http://teamreview.codeplex.com/Release/ProjectReleases.aspx?ReleaseId=27776

Thanks,

Commented Issue: WorkItemQuery List (drop downs) silently error if duplicate work item query name exists (ie public and private query with same name)

JBBrown — Tue, 04 Aug 2009 21:01:24 GMT

JB: I don't know why we missed this in release 1.1.0 - that was a mistake - it should have been included. I'll slate it for the next release.

With the addition of sorting logic to put work item queries in alphabetical order, there is now a bug that occurs if two work item queries have the same name. This is possible when a private user query is the same name as a public/team query.

This bug occurs when creating a new code review response (when binding the queries to the combo box) as well as when replaying a code review (to build the similar work item query list).

Since a dictionary is used internally to sort the results by name, if a duplicate name exists, it cannot be added to the dictionary.

Proposed solution - Ensure each work item "name" as put into the dictionary is unique. Also identify private queries from public queries (to assist a user in the case of duplicate names).

1. Put all private / My Queries at the beginning of the list
2. Append [My Query] to the name of all private queries
3. Defensively check for any duplicate names (after the "My Query" is appended) and append the query's GUID if duplicate is found.
Comments: ** Comment from web user: JBBrown **

This fix was published today in release 1.1.1 - http://teamreview.codeplex.com/Release/ProjectReleases.aspx?ReleaseId=27776

Thanks,

Commented Issue: 1.1.0 not working for VB and languages without language support like HTML

JBBrown — Tue, 04 Aug 2009 21:01:09 GMT

the codelanguage attached to VB documents is "Basic" which doesn't coorespond to an item in the CodeLangage enum. Instead the enum has Vb.

Othe files without language support are also failing due to a removed catch block.
Comments: ** Comment from web user: JBBrown **

This fix was published today in release 1.1.1 - http://teamreview.codeplex.com/Release/ProjectReleases.aspx?ReleaseId=27776

Thanks,

Commented Issue: error when trying to associate my check-in to a Code Review Resonse work item

JBBrown — Tue, 04 Aug 2009 21:00:57 GMT

From http://teamreview.codeplex.com/Thread/View.aspx?ThreadId=61940

Hi,
I'm always getting the following error when trying to associate my check-in to a Code Review Resonse work item:
Changeset 735 successfully checked in.
Failed to update the following work item:

ID 1097. Reason: TF26194: The value for this field cannot be changed.
It happens whether I choose 'associate' or 'resolve'.
I've only installed the add-in last week so don't think its to do with the bug that was fixed in May (JBBrown's post in May 25).
Does anyone know how to make this work?
Thanks,
- Frank.
Comments: ** Comment from web user: JBBrown **

This fix was published today in release 1.1.1 - http://teamreview.codeplex.com/Release/ProjectReleases.aspx?ReleaseId=27776

Thanks,