Error when associating changeset

Jul 9, 2009 at 5:58 AM

Hi,

I'm always getting the following error when trying to associate my check-in to a Code Review Resonse work item:

Changeset 735 successfully checked in.
Failed to update the following work item:

ID 1097. Reason: TF26194: The value for this field cannot be changed. 

It happens whether I choose 'associate' or 'resolve'.

I've only installed the add-in last week so don't think its to do with the bug that was fixed in May (JBBrown's post in May 25).

Does anyone know how to make this work?

Thanks,
- Frank.

Jul 20, 2009 at 4:36 AM

Just bumping it to see if anyone else has the same problem (or does not have the same problem) using v1.1.0?

I've tried it on another developer's machine and he gets the same error.

Interestingly, using an older version (v1.0.9) works fine but we would prefer to be using the latest version.

- Frank.

Coordinator
Jul 20, 2009 at 5:32 AM

Ok I can reproduce the behaviour and will investigate further.

Coordinator
Jul 21, 2009 at 4:11 AM

The problem is due to a conflict between the TFS checkin window and updating the replay window grid/list of items.

If you have the source code, in CodeReviewReplayWindow.cs change GetVersionControl method to below:-

        private void GetVersionControl()
        {          
            if (TFSService.VersionControlExt != null)
            {
                SetTfsServer();
                SetResultGridEvents();              
            }
            if (TFSService.VersionControlServer != null)
            {
                TFSService.VersionControlServer.BeforeCheckinPendingChange +=
                    new ProcessingChangeEventHandler(VersionControlServer_BeforeCheckinPendingChange);
                TFSService.VersionControlServer.AfterWorkItemsUpdated +=
                    new AfterWorkItemsUpdatedEventHandler(VersionControlServer_AfterWorkItemsUpdated);
            }
        }
 
Add these methods
        void VersionControlServer_AfterWorkItemsUpdated(object sender, WorkItemsUpdateEventArgs e)
        {
            if (documentService != null)
            {
                documentService.DocumentAdded +=
                    new DocumentService.DocumentServiceEventHandler(documentService_DocumentAdded);
            }
        }

        void VersionControlServer_BeforeCheckinPendingChange(object sender, ProcessingChangeEventArgs e)
        {
            if (documentService != null)
            {
                documentService.DocumentAdded -=
                    new DocumentService.DocumentServiceEventHandler(documentService_DocumentAdded);
            }
        }
 
In TFSService.cs change property to:-

 

public static VersionControlServer VersionControlServer

 

{
get { return versionControlServer;
}
Recompile/test and deploy
Coordinator
Jul 27, 2009 at 6:35 PM

These changes checked in in Changeset #3894

 

Thanks

JB

Coordinator
Aug 4, 2009 at 9:59 PM

This fix was published today in release 1.1.1 - http://teamreview.codeplex.com/Release/ProjectReleases.aspx?ReleaseId=27776 

 

Thanks,

JB

Aug 5, 2009 at 12:46 AM

The new version works great.

Thanks JB :)

- Frank.